Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: apply_map() missing 1 required positional argument: 'scoped_logic' #2941

Open
SilviaAmAm opened this issue Mar 28, 2023 · 3 comments
Assignees

Comments

@SilviaAmAm
Copy link
Contributor

SilviaAmAm commented Mar 28, 2023

Product versie / Product version

2.1.x

Omschrijf het probleem / Describe the bug

Sentry 328205

I saw this in the DH sentry, but it wasn't reported by them.

Using wrong JSON logic crashes form

Stappen om te reproduceren / Steps to reproduce

Create a form with:

  • A IBAN component with label iban
  • A radio component with variable options with the wrong json expression: {"map": [{"var": "iban"}]}

Fill in the form:

  • Enter an iban in the iban component
  • The form step crashes => The GET to the form step gives a 500

Verwacht gedrag / Expected behavior

I guess ideally the error should be caught when the form designer tries to save the form?

Screen resolution

None

Device

None

OS

None

Browser

No response

@SilviaAmAm SilviaAmAm added the bug Something isn't working label Mar 28, 2023
@joeribekker joeribekker added this to the Release 2.2.0 milestone Apr 3, 2023
@joeribekker
Copy link
Contributor

Refinement: Related to #2324

@CharString CharString moved this from Todo to In Progress in Development Apr 3, 2023
@CharString CharString moved this from In Progress to Todo in Development Apr 3, 2023
@sergei-maertens
Copy link
Member

open-formulieren/InferNoLogic#1 will result in a client-side type checker that should prevent this. Leaving this ticket here as a specific check for integrating the type checker in the form designer.

@joeribekker
Copy link
Contributor

Type inference feature was cancelled due to implementation difficulties vs benefits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants