-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix depr warning by updating import: xblockutils -> xblock.utils #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for preparing this, @kdmccormick!
One request - could we make this change backward-compatible, as, e.g., we did here (ref)?
We won't need these fallbacks in tests, though.
80ab62d
to
a6eb0c6
Compare
Context: openedx/XBlock#675 This fixes some edx-platform warnings: /openedx/venv/lib/python3.8/site-packages/poll/poll.py:40: DeprecatedPackageWarning: Please use import xblock.utils.publish_event instead of xblockutils.publish_event because the 'xblock-utils' package has been deprecated and migrated to within 'xblock' package. Uses a try-catch for backwards compatibility with pre-Quince versions of xblock and xblockutils. Bump from 1.13.0 to 1.13.1
Sure thing @Agrendalath . Ready for another look. |
|
Good questions @Agrendalath . I wasn't aware that not all modules were copied from xblockutils to xblock.utils. I see the justification for removing base_test.py is that bok-choy is deprecated, but it seems like xblock-poll uses base_test.py for integration testing without actually relying on bok-choy at all. The integration tests seem to be working fine in this repository and I'd hate to remove them for no reason. I'm wondering now whether it was a mistake to drop base_test.py. What do you think? |
It looks like My suggestion is that since |
@kdmccormick its under discussion here |
@bradenmacdonald and @Agrendalath : @farhan dug in and found that SeleniumXBlockTest was actually using bok-choy's WebAppTest as a base, so it seems that it was right to remove it instead of pulling it into XBlock. Unless you have any objections, I'll remove this XBlock's selenium tests and update requirements/base.in to point at |
This ended up being more work than I'm able to take on right now. I'm going to add some notes to #114 and close this. Feel free to re-use this PR in the future if that's helpful. |
Context: openedx/XBlock#675
Fixes some edx-platform warnings:
Uses a try-catch for backwards compatibility with pre-Quince versions
of xblock and xblockutils
Bumps version from 1.13.0 to 1.13.1
Resolves #114.