Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

semver.io is flakey - wrong node version #43

Open
lirbank opened this issue May 28, 2014 · 2 comments · May be fixed by #44
Open

semver.io is flakey - wrong node version #43

lirbank opened this issue May 28, 2014 · 2 comments · May be fixed by #44

Comments

@lirbank
Copy link

lirbank commented May 28, 2014

When I was setting up a new Heroku app today it was installed with node version 0.10.21 (which totally does not work with the latest Meteor version).

----> Fetching custom git buildpack... done
-----> Meteor app app detected
-----> Resolving engine versions

       No version of Node.js specified in nodeversion, using '0.10.26'

       Using Node.js version: 0.10.21
-----> Fetching Node.js binaries
        - downloading and extracting node from http://s3pository.heroku.com/node/v0.10.21/node-v0.10.21-linux-x64.tar.gz

So I investigated it a bit and found that semver.io changes its response with each other request. I just ran curl multiple times from the command line and got this:

$ curl --silent --get --data-urlencode "range=0.10.26" https://semver.io/node/resolve
0.10.21
$ curl --silent --get --data-urlencode "range=0.10.26" https://semver.io/node/resolve
0.10.21
$ curl --silent --get --data-urlencode "range=0.10.26" https://semver.io/node/resolve
0.10.26
$ curl --silent --get --data-urlencode "range=0.10.26" https://semver.io/node/resolve
0.10.26
$ curl --silent --get --data-urlencode "range=0.10.26" https://semver.io/node/resolve
$ curl --silent --get --data-urlencode "range=0.10.26" https://semver.io/node/resolve
0.10.21
$ curl --silent --get --data-urlencode "range=0.10.26" https://semver.io/node/resolve
0.10.21
$ curl --silent --get --data-urlencode "range=0.10.26" https://semver.io/node/resolve
0.10.21
$ curl --silent --get --data-urlencode "range=0.10.26" https://semver.io/node/resolve
0.10.26
$ curl --silent --get --data-urlencode "range=0.10.26" https://semver.io/node/resolve
0.10.26
$ curl --silent --get --data-urlencode "range=0.10.26" https://semver.io/node/resolve
0.10.21
$ curl --silent --get --data-urlencode "range=0.10.26" https://semver.io/node/resolve
0.10.26
$ curl --silent --get --data-urlencode "range=0.10.26" https://semver.io/node/resolve
0.10.26
$ curl --silent --get --data-urlencode "range=0.10.26" https://semver.io/node/resolve
0.10.26
$ curl --silent --get --data-urlencode "range=0.10.26" https://semver.io/node/resolve
0.10.21

Probably not a good thing to continue using samver. Working on a fix, will make a Pull Request shortly.
@lirbank lirbank linked a pull request May 28, 2014 that will close this issue
Open
@jtwalters
Copy link

My meteor app appears to be working fine with node 0.10.28. Where does it say meteor doesn't work with node 0.10.x? According to this meteor blog post it's been dependent on 0.10 for a while.

@lirbank
Copy link
Author

lirbank commented Aug 31, 2014

This issue is about semver.io responding with random node versions. See my tests above, I was running the same command ($ curl --silent --get --data-urlencode "range=0.10.26" https://semver.io/node/resolve) many times. Below you see the responses each one you see what samver responded (sometimes 0.10.26 and sometimes 0.10.21).

So when you create a Heroku app you will randomely set it up with node 0.10.21 or 0.10.26. So I suggest we don't rely on samver and remove it from the build package, see PR #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Samver can't be relied on, removing it
2 participants
@jtwalters @lirbank