From cd5c179dd64547875bedc083eae80463a34899c1 Mon Sep 17 00:00:00 2001 From: Simone Basso Date: Thu, 20 Feb 2020 17:21:49 +0100 Subject: [PATCH 1/3] ts-018-whatsapp.md: ack CIDR logic being broken It's probably wise to mention this in the spec because it has impacts on the data quality, because most tests now result into an anomaly. --- nettests/ts-018-whatsapp.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/nettests/ts-018-whatsapp.md b/nettests/ts-018-whatsapp.md index e7cf0fe1..cdaae7f4 100644 --- a/nettests/ts-018-whatsapp.md +++ b/nettests/ts-018-whatsapp.md @@ -547,3 +547,12 @@ The meaning of the various keys is described in the above section. "test_version": "0.5.0" } ``` + +## Bugs + +Since 2020-02-17, the heristics for checking whether a netblock belongs to +WhatsApp as described in version 2016-10-25-001 of this specification is +fundamentally broken (see [ooni/probe-engine#341]( +https://github.com/ooni/probe-engine/issues/341)). This issue affected +ooni/probe-legacy <= 2.3.0, ooni/probe-ios <= 2.2.0, ooni/probe-android +<= 2.2.0. From b72fc1c86e6e117457244599162932ba44a4a2fb Mon Sep 17 00:00:00 2001 From: Simone Basso Date: Thu, 20 Feb 2020 17:27:00 +0100 Subject: [PATCH 2/3] Update ts-018-whatsapp.md --- nettests/ts-018-whatsapp.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/nettests/ts-018-whatsapp.md b/nettests/ts-018-whatsapp.md index cdaae7f4..9dc47c3d 100644 --- a/nettests/ts-018-whatsapp.md +++ b/nettests/ts-018-whatsapp.md @@ -80,6 +80,9 @@ consider the endpoint to be blocked and write in the report: } ``` +Since 2020-02-17, this methodology has started failing consistently as +documented in the bugs section at the end of this document. + For every IP, both consistent and inconsistent, we then try to establish a TCP session to port `443` and `5222`. @@ -555,4 +558,6 @@ WhatsApp as described in version 2016-10-25-001 of this specification is fundamentally broken (see [ooni/probe-engine#341]( https://github.com/ooni/probe-engine/issues/341)). This issue affected ooni/probe-legacy <= 2.3.0, ooni/probe-ios <= 2.2.0, ooni/probe-android -<= 2.2.0. +<= 2.2.0. The `test_version` was 0.6.0 for ooni/probe-legacy and 0.6.1 +for the mobile apps. Since Measurement Kit 0.10.10 (`test_version` +0.7.0) we will completely disable such check. From 2f97a1c5ecec19371a4393eb73729fc79b76a266 Mon Sep 17 00:00:00 2001 From: Simone Basso Date: Thu, 20 Feb 2020 17:31:29 +0100 Subject: [PATCH 3/3] Update ts-018-whatsapp.md --- nettests/ts-018-whatsapp.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nettests/ts-018-whatsapp.md b/nettests/ts-018-whatsapp.md index 9dc47c3d..64988b47 100644 --- a/nettests/ts-018-whatsapp.md +++ b/nettests/ts-018-whatsapp.md @@ -80,7 +80,7 @@ consider the endpoint to be blocked and write in the report: } ``` -Since 2020-02-17, this methodology has started failing consistently as +Since 2020-02-17, this consistency check has started failing consistently as documented in the bugs section at the end of this document. For every IP, both consistent and inconsistent, we then try to establish a TCP session to port `443`