Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify logic for determining what tests should run #2806

Open
hellais opened this issue Oct 10, 2024 · 0 comments
Open

Simplify logic for determining what tests should run #2806

hellais opened this issue Oct 10, 2024 · 0 comments
Labels
bug Something isn't working enhancement improving existing code or new feature ooni/probe-engine triage

Comments

@hellais
Copy link
Member

hellais commented Oct 10, 2024

We recently noticed that echcheck wasn't running because the Factory initializer didn't have enabledByDefault initialized.

In general it seems like we have multiple places that can affect wether a test may run or not:

  • flags inside of the engine
  • list of tests in a group in engine
  • list of tests in a group in apps
  • backend related feature flags

On top of this, it seems like we also apply some caching to some of these, making it harder to understand why something is not running and what the cause is.

Ideally we would consolidate this into a single source of truth and simplify all the engine related code.

In the future the source of truth will be the OONI Run link descriptors and we probably only care to selectively disable tests from the backend.

@hellais hellais added bug Something isn't working enhancement improving existing code or new feature triage ooni/probe-engine labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement improving existing code or new feature ooni/probe-engine triage
Projects
None yet
Development

No branches or pull requests

1 participant