Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: unify code implementing Submitter and Experiment.OpenReport #2608

Open
bassosimone opened this issue Oct 24, 2023 · 1 comment
Open

engine: unify code implementing Submitter and Experiment.OpenReport #2608

bassosimone opened this issue Oct 24, 2023 · 1 comment
Assignees
@bassosimone
Labels
cleanup There's need to cleanup stuff a bit ooni/probe-engine priority/low

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Oct 24, 2023 •
edited
Loading

The engine codebase allows submitting measurements using two mechanisms. There are methods of the engine.Experiment type and there is the engine.Submitter. We should probably have a single implementation implementing both APIs such that we don't need to change existing code but we reduce code complexity.
@bassosimone bassosimone self-assigned this Oct 24, 2023
@bassosimone bassosimone changed the title engine: remove submitter from experiment engine: always use engine.Submitter Oct 24, 2023
@bassosimone bassosimone mentioned this issue Nov 21, 2023
Closed
26 tasks
@bassosimone
Copy link
Contributor Author

When implementing #2607, we chose another approach, given that it was possible to adapt the code without doing this refactoring. We may still want to make this change sometime in the future.

@bassosimone bassosimone changed the title engine: always use engine.Submitter engine: unify code implementing Submitter and Experiment.OpenReport Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
cleanup There's need to cleanup stuff a bit ooni/probe-engine priority/low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bassosimone