feat: add counts to summary cards #352
Conversation
| countByResultId: | ||
| SELECT | ||
| COUNT(*) AS total_measurements, | ||
| SUM(CASE WHEN is_rerun = 0 AND is_done = 1 AND is_failed = 0 AND is_anomaly = 0 THEN 1 ELSE 0 END) AS ok_measurements, | ||
| SUM(CASE WHEN is_rerun = 0 AND is_done = 1 AND is_failed = 1 THEN 1 ELSE 0 END) AS failed_measurements | ||
| FROM Measurement | ||
| WHERE result_id = ?; |
There was a problem hiding this comment.
Do we need the extra DB query? Can't we just get this values from the whole list?
| @@ -2,11 +2,14 @@ package org.ooni.probe.data.models | |||
|
|
|||
| import kotlin.time.Duration.Companion.seconds | |||
|
|
|||
| data class ResultCount(val total: Long, val failed: Long?, val succeeded: Long?) | |||
There was a problem hiding this comment.
Why could failed and succeeded be null?
| @@ -2,6 +2,10 @@ package org.ooni.probe.data.models | |||
|
|
|||
| import kotlin.time.Duration.Companion.seconds | |||
|
|
|||
| data class ResultCount(val total: Long, val succeeded: Long) { | |||
| val failed get() = total - succeeded | |||
There was a problem hiding this comment.
I just realised that we're mixing failed and anomalies here.
Blocked = isAnomaly
Failed = isFailed
We shouldn't be counting failures inside the blocked count.
| <string name="TestResults_Summary_Websites_Hero_Tested_Singular">Tested</string> | ||
| <string name="TestResults_Summary_Websites_Hero_Blocked_Singular">Blocked</string> | ||
| <string name="TestResults_Summary_Websites_Hero_Reachable_Singular">Accessible</string> |
There was a problem hiding this comment.
There are different strings for circunvention, websites and instant messaging
There was a problem hiding this comment.
Its thesame string. I doubt we want to keep 12+ strings saying similar things.
There was a problem hiding this comment.
I don't know about other languages, but at least in English, Instant Messaging uses accessible and Circumvention uses available.
Closes #341