Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

whatsapp: make sure we can pass the AllEndpoints option from mobile #743

Closed
bassosimone opened this issue Jun 30, 2020 · 2 comments
Closed

whatsapp: make sure we can pass the AllEndpoints option from mobile #743

bassosimone opened this issue Jun 30, 2020 · 2 comments
Assignees
@bassosimone
Labels
effort/S Small effort priority/high High priority
Milestone
Sprint 17 - Θέτις

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Jun 30, 2020 •
edited
Loading

This probably requires some refactoring in the way in which we process options in oonimkall.
@bassosimone bassosimone added this to the Sprint 17 - Θέτις milestone Jun 30, 2020
@bassosimone bassosimone self-assigned this Jun 30, 2020
@bassosimone bassosimone mentioned this issue Jun 30, 2020
Closed
@bassosimone bassosimone changed the title whatsapp: rewrite in Go (2/2) whatsapp: make sure we can pass the AllEndpoints option from mobile Jul 2, 2020
@bassosimone bassosimone added priority/high High priority effort/M Medium effort effort/S Small effort and removed effort/M Medium effort labels Jul 2, 2020
bassosimone added a commit that referenced this issue Jul 9, 2020
@bassosimone
whatsapp: make sure we don't violate v2020-07-09-001 of the spec
3edc726 
1. remove the AllEndpoints option, which was basically increasing the
probability of detecting false positives

2. make sure we report the blocked WhatsApp endpoints (a concept
different from a TCP endpoint) like the spec says

Part of #743
@bassosimone bassosimone mentioned this issue Jul 9, 2020
Merged
bassosimone added a commit that referenced this issue Jul 9, 2020
@bassosimone
whatsapp: make sure we don't violate v2020-07-09-001 of the spec (#752)
815231b 
1. remove the AllEndpoints option, which was basically increasing the
probability of detecting false positives

2. make sure we report the blocked WhatsApp endpoints (a concept
different from a TCP endpoint) like the spec says

Part of #743
@bassosimone
Copy link
Contributor Author

Turns out the AllEndpoints options is bad. It's disabled by default, which increases the probability that we'll hit false positives. So, I have removed the option from the implementation.

I will create an issue for @lorenzoPrimi to remember to remove the option from the settings. In the meantime, I will also change the code to accept the option with a warning. This will reduce the chances that we will screw up and deploy an app where WhatsApp does not even start.

bassosimone added a commit that referenced this issue Jul 9, 2020
@bassosimone
oonimkall: make AllEndpoints presence non fatal
c90f9c4 
Part of #743 (comment)

While there, make the corresponding unit test much more precise
This was referenced Jul 9, 2020
Merged
Closed
bassosimone added a commit that referenced this issue Jul 9, 2020
@bassosimone
oonimkall: make AllEndpoints presence non fatal (#753)
2e72e69 
Part of #743 (comment)

While there, make the corresponding unit test much more precise
@bassosimone
Copy link
Contributor Author

We have merged the above mentioned changes and created a follow-up issue. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
effort/S Small effort priority/high High priority
Projects
None yet
Milestone
Sprint 17 - Θέτις
Development

No branches or pull requests
1 participant
@bassosimone