Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netx: MeasurementRoot: add RoundTrip hook #233

Closed
bassosimone opened this issue Nov 27, 2019 · 1 comment
Closed

netx: MeasurementRoot: add RoundTrip hook #233

bassosimone opened this issue Nov 27, 2019 · 1 comment
Assignees
Labels
effort/XS Extra small effort enhancement New feature or request ooni/netx Issues related to github.com/ooni/netx priority/low Low priority

Comments

@bassosimone
Copy link
Contributor

I recently gave an internal presentation to @ooni where I said that certain actions are not easy because we do not have a way to override the RoundTrip on a per request basis. Yet, if we add a RoundTrip hook to MeasurementRoot, that becomes easy to do. This can be useful to implement the ooni/netx#127 use case, for example, without changing the core implementation. Another use case is that it could allow us to use a different TLS implementation (see #229).

@bassosimone bassosimone changed the title MeasurementRoot: add RoundTrip hook netx: MeasurementRoot: add RoundTrip hook Jan 12, 2020
@bassosimone bassosimone transferred this issue from ooni/netx Jan 12, 2020
@bassosimone bassosimone added discuss effort/M Medium effort priority/low Low priority ooni/netx Issues related to github.com/ooni/netx effort/XS Extra small effort enhancement New feature or request and removed discuss effort/M Medium effort labels Jan 12, 2020
@bassosimone bassosimone self-assigned this Feb 17, 2020
@bassosimone
Copy link
Contributor Author

I spent some time experimenting with this concept in Sprint 9. I concluded that this is not desirable and that we should specifically see to reduce the amount of context usage to the minimum.

My conclusions are summarized at #359.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/XS Extra small effort enhancement New feature or request ooni/netx Issues related to github.com/ooni/netx priority/low Low priority
Projects
None yet
Development

No branches or pull requests

1 participant