From d84729dcd342bad16f338d3476b6c2ac47d705b2 Mon Sep 17 00:00:00 2001 From: Simone Basso Date: Fri, 1 Dec 2023 13:40:22 +0100 Subject: [PATCH] doc(webconnectivitylte): document "orig" HTTP analysis bug (#1422) See https://github.com/ooni/probe/issues/2641 --- internal/experiment/webconnectivitylte/analysishttpcore.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/internal/experiment/webconnectivitylte/analysishttpcore.go b/internal/experiment/webconnectivitylte/analysishttpcore.go index e465ef047f..5e4280853f 100644 --- a/internal/experiment/webconnectivitylte/analysishttpcore.go +++ b/internal/experiment/webconnectivitylte/analysishttpcore.go @@ -31,6 +31,10 @@ func (tk *TestKeys) analysisHTTPToplevel(logger model.Logger) { if len(tk.Requests) <= 0 { return } + // TODO(https://github.com/ooni/probe/issues/2641): this code is wrong + // with redirects because LTE only creates an HTTP request when it reaches + // the HTTP stage, so a previous redirect that is successful would cause + // this code to say we're good on the HTTP front, while we're not. finalRequest := tk.Requests[0] if finalRequest.Failure != nil { tk.HTTPExperimentFailure = optional.Some(*finalRequest.Failure)