CustomTooltip: change link to measurements #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If time grain isn't "day", use ( start + time grain ) as until
|
@Lanius-collaris is attempting to deploy a commit to the OONI Team on Vercel. A member of the Team first needs to authorize it. |
|
CC @hellais |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
majakomel
requested changes
Jan 6, 2024
There was a problem hiding this comment.
Hi @Lanius-collaris, thanks for your contribution! The code looks good, but I'd like to ask for a change in behaviour - currently time is included for all until filters, but it would preferably be only date when time_grain is day/week/month (hour is fine as is).
majakomel
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If time grain isn't "day", use ( start + time grain ) as until
Resolves #864