Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible improvements of this package #18

Open
hirasso opened this issue Jun 24, 2024 · 1 comment
Open

Possible improvements of this package #18

hirasso opened this issue Jun 24, 2024 · 1 comment

Comments

@hirasso
Copy link

hirasso commented Jun 24, 2024

Hi @ooksanen !

As I was implementing the PR #17 , I noticed a few chances for enhancements. I'd be happy to take care of them, as I'm planning on using this package in many (if not all) future projects.

  1. There is a lot of commented out code in https://github.com/ooksanen/acf-focuspoint/blob/master/fields/class-acffp-acf-field-focuspoint-v5.php – Would you agree that this could be removed?
  2. Would you be fine with introducing an .editorconfig so that if other contributors would edit the files, they would not mess with the formatting? I needed to manually "save without formatting" so that you wouldn't be overwhelmed with changes all over the place. As I'm a maintainer of the package swup and have quite some experience with these kinds of things, I could take care of that, too.
  3. I would like it if the focus point couldn't only be set by a click, but if it would be draggable, as well. What do you think about that?

Also, if you are not using this package anymore and don't want to maintain it, I would gladly take it over. We could discuss the "how" in a call if you'd like.

@hirasso
Copy link
Author

hirasso commented Jul 30, 2024

...alternatively, if you don't have the resources to maintain this plugin anymore, I'd be open to discuss taking over the package and continue to develop and maintain it. If you find this interesting, we could meet in a call sometime and discuss the transition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant