Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validation for mappings creation/edition #41

Open
syphax-bouazzouni opened this issue Oct 7, 2022 · 0 comments
Open

add validation for mappings creation/edition #41

syphax-bouazzouni opened this issue Oct 7, 2022 · 0 comments
Assignees

Comments

@syphax-bouazzouni
Copy link

syphax-bouazzouni commented Oct 7, 2022

Currently with the API we can create a mapping with empty classes, because no validation was done.

I implemented a size validator for the attribute classes to enforce the size 2.
https://github.com/ontoportal-lirmm/ontologies_linked_data/blob/development/lib/ontologies_linked_data/models/mappings/mapping.rb#L26

But this validator need to be enhanced to catch the sort of errors of empty string, e.g ["class_uri_1", ""] is valid currently and same for ["", ""].

Another enhancement is also to add the validator to goo like the existing ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants