Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE11 support (polyfill) #40

Open
joepio opened this issue May 24, 2019 · 5 comments
Open

IE11 support (polyfill) #40

joepio opened this issue May 24, 2019 · 5 comments
Assignees
@joepio
Labels
bug Something isn't working

Comments

@joepio
Copy link
Member

joepio commented May 24, 2019

Currently, the application does not properly function in Internet Explorer. Since a large portion of our potential users (government officials) tends to use IE, we should explore whether we could support it.
@joepio joepio self-assigned this May 24, 2019
@joepio
Copy link
Member Author

joepio commented May 24, 2019

https://www.browserling.com/browse/win/7/ie/11/http%3A%2F%2Fori.argu.co

Screenshot 2019-05-24 at 12 42 28

@joepio joepio closed this as completed May 24, 2019
@joepio joepio reopened this May 24, 2019
@joepio
Copy link
Member Author

joepio commented May 24, 2019

@Fletcher91 Could you take a look at this? Might be a link-lib or rdfjs issue.

joepio added a commit that referenced this issue May 27, 2019
@joepio
Polyfill IE11 #40
306fbd7
@joepio
Copy link
Member Author

joepio commented May 27, 2019

Turns out we needed to add some polyfills for IE11 support. I've added default polyfills (should at least fix the above issue, which required an Array polyfill). I'll test it when the next build is deployed. This requires a new release of reactivesearch.

@joepio joepio changed the title Explore IE11 support IE11 support (polyfill) May 27, 2019
joepio added a commit that referenced this issue May 29, 2019
@joepio
Page Loader, old browser hint #40
3abe25f
@joepio joepio mentioned this issue Jun 5, 2019
Closed
@joepio joepio added the bug Something isn't working label Jun 5, 2019
@joepio joepio closed this as completed Jul 17, 2019
@joepio joepio reopened this Oct 14, 2019
joepio added a commit that referenced this issue Oct 14, 2019
@joepio
Add globalThis polyfill #40
bc62987
joepio added a commit that referenced this issue Oct 15, 2019
@joepio
Fix globalthis #40
cfdcf24
joepio added a commit that referenced this issue Oct 22, 2019
@joepio
ungap globalthis #40
7b402dc
@joepio
Copy link
Member Author

joepio commented Oct 25, 2019

Okay, this does not work. This needed to be fixed upstream in link-redux. I've made a branch that upgrades link-redux and other dependencies, which should fix this issue. @Fletcher91 is working on it.

joepio added a commit that referenced this issue Oct 25, 2019
@joepio
Try es3 for IE11 compatibility #40
5007b55
@joepio
Copy link
Member Author

joepio commented Oct 25, 2019 •
edited
Loading

Fixed previous issue with ce85679.

However, there still is a JS parsing issue in IE11 (in Validator.js). I'll try compiling to ES3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joepio joepio

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rescribet @joepio