Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add signer #3

Merged
merged 6 commits into from
Dec 13, 2024
Merged

[WIP] Add signer #3

merged 6 commits into from
Dec 13, 2024
+1,767 −11,092

Conversation

lmcmz
Copy link
Collaborator

@lmcmz lmcmz commented Apr 17, 2023

Closes: #2

Description

Add signer for transaction

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@lmcmz lmcmz requested a review from rmberg as a code owner April 17, 2023 15:22
@lmcmz lmcmz marked this pull request as draft April 17, 2023 15:22
@lmcmz lmcmz marked this pull request as ready for review December 13, 2024 06:11
@lmcmz
Copy link
Collaborator Author

lmcmz commented Dec 13, 2024

Merge it for now, add the signer in following PRs

@lmcmz lmcmz merged commit 2ec1710 into main Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmberg rmberg rmberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve sign method for flow transaction
2 participants
@lmcmz @rmberg