Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facilitate Switch to Dependency Manager on Existing Projects #1544

Open
chasefleming opened this issue Apr 25, 2024 · 3 comments
Open

Facilitate Switch to Dependency Manager on Existing Projects #1544

chasefleming opened this issue Apr 25, 2024 · 3 comments
Assignees
Labels
Feature A new user feature or a new package API Feedback

Comments

@chasefleming
Copy link
Member

In order to more easily migrate people with existing projects to use Dependency Manager, we should facilitate the switch easily. This means:

  • And existing project adds a dependency
  • If it detects that dependency in contracts it asks the user if they'd like to remove it from contracts since it will be in dependencies
  • It pulls the aliases (may request permission)
  • It gives a summary of files you can now delete from your project
@chasefleming chasefleming added Feature A new user feature or a new package API Feedback labels Apr 25, 2024
@chasefleming chasefleming self-assigned this Apr 25, 2024
@chasefleming chasefleming moved this to 🔖 Ready for Pickup in 🌊 Flow 4D Apr 25, 2024
@btspoony
Copy link

There are still some incompatibilities with the dependency manager in VS Code.
I have to configure the same contract twice in contracts and dependencies to ensure that flow.json works properly.

Of course, the advantage is that I don't have to submit these contracts to the repo anymore, because they are under imports folder.

For your refer:
onflow/vscode-cadence#542

@github-project-automation github-project-automation bot moved this from 🔖 Ready for Pickup to ✅ Done in 🌊 Flow 4D Apr 30, 2024
@chasefleming chasefleming reopened this Apr 30, 2024
@chasefleming
Copy link
Member Author

I'm not sure this is related to this ticket, but it looks like it was resolved on the linked issue.

@btspoony
Copy link

btspoony commented May 1, 2024

Yeah, I found that it has been fixed in flow-cli v1.18.0 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new user feature or a new package API Feedback
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants