Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Changesets bot bumping peer dependencies to next major version #1777

Open
jribbink opened this issue Sep 7, 2023 · 0 comments
Open
Labels
Bug Something isn't working

Comments

@jribbink
Copy link
Contributor

jribbink commented Sep 7, 2023

Current Behavior

The changesets bot seems to bump peer dependencies to the next major version (i.e. FCL-WC) despite them not needing to be bumped. In spite of having no breaking changes since 1.0.0, FCL-WC is now at v4.0.0. This is problematic because now users need to explicitly upgrade to the new version (v4.0.0) to receive bug fixes/minor changes and the actual changes to the package do not conform with what would be expected based on semver.

see: #1770

Re. fcl-wc: while we could technically unpublish v4.0.0, it's probably not exactly doable since it has quite a few downloads already. It would break existing projects which now depend on this version so there's not a lot we can do here. It's a little unfortunate that the version has ballooned as it has, but the important part is that we resolve this issue (even if it's just with some sort of hack) to prevent this from happening again.

Expected Behavior

FCL-WC version does not get major bump when FCL gets a minor change.

Steps To Reproduce

Make a minor change to FCL & make PR (or just run npx changeset version)

#1770

Environment

n/a

What are you currently working on that this is blocking?

No response

@jribbink jribbink added the Bug Something isn't working label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant