Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LS] Update access modifiers to Cadence 1.0 #445

Merged
merged 1 commit into from
Nov 4, 2024
Merged

[LS] Update access modifiers to Cadence 1.0 #445

merged 1 commit into from
Nov 4, 2024

Conversation

turbolent
Copy link
Member

Description

pub, priv, and pub(set) got removed in Cadence 1.0, so they should not be proposed anymore. Instead propose access(all)

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Oct 25, 2024
@turbolent turbolent requested a review from SupunS as a code owner October 25, 2024 18:50
@turbolent turbolent mentioned this pull request Oct 25, 2024
Closed
@turbolent turbolent merged commit 9b8e088 into master Nov 4, 2024
10 checks passed
@turbolent turbolent deleted the bastian/fix-priv-pub branch November 4, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

Assignees

@turbolent turbolent

Labels
bugfix Language Server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbolent @SupunS