Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Remove redundant compilation flags #951

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CMake] Remove redundant compilation flags #951

wants to merge 1 commit into from
+0 −4

Conversation

KFilipek
Copy link
Contributor

@KFilipek KFilipek commented Nov 29, 2024 •
edited
Loading

This change removes all unnecessary flags that are enabled by other flags like -Wall, -Wextra, -Wpedantic

Resolves #944

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@KFilipek
[CMake] Remove redundant compilation flags
971113d 
This change removes all unnecessary flags that are enabled
by other flags like -Wall, -Wextra, -Wpedantic

Signed-off-by: Krzysztof Filipek <[email protected]>
@KFilipek KFilipek self-assigned this Nov 29, 2024
@KFilipek KFilipek marked this pull request as ready for review November 29, 2024 11:42
@KFilipek KFilipek requested a review from a team as a code owner November 29, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatKamin PatKamin PatKamin approved these changes

@bratpiorka bratpiorka bratpiorka approved these changes

Assignees

@KFilipek KFilipek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify compilation flags in CMake
3 participants
@KFilipek @bratpiorka @PatKamin