Update params implementation #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinser52
force-pushed
the
svinogra_config_params
branch
from
79b90ba
to
67570d5
Compare
vinser52
force-pushed
the
svinogra_config_params
branch
3 times, most recently
from
c67f102
to
a3050d4
Compare
vinser52
force-pushed
the
svinogra_config_params
branch
from
a3050d4
to
05a44a0
Compare
|
Disjoint pool changes look good (but you should probably change umfDisjointPoolParamsSetName to use deep copy as marked in the comment.) |
igchor
reviewed
Nov 18, 2024
vinser52
force-pushed
the
svinogra_config_params
branch
from
05a44a0
to
ab46aaf
Compare
lplewa
reviewed
Nov 19, 2024
vinser52
force-pushed
the
svinogra_config_params
branch
from
ab46aaf
to
477c341
Compare
Done |
bratpiorka
approved these changes
Nov 19, 2024
vinser52
force-pushed
the
svinogra_config_params
branch
from
477c341
to
056e493
Compare
vinser52
force-pushed
the
svinogra_config_params
branch
from
056e493
to
9d74c17
Compare
|
@pbalcer @igchor I just tested this version of UMF with the 2025.0 compiler. Seems it works. Looks like this change does not break ABI. Of course, I run just a single test app, but it works. I understand that UR needs to be updated to use the new API, but I hope having ABI compatibility decreases the probability that we will break compiler CI with this transition. |
igchor
approved these changes
Nov 19, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref. #844
Checklist