-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement backward compatibility support in UMF #908
Comments
But the "ops->version == UMF_VERSION_CURRENT" assert is fine. We want to bump "UMF_VERSION_CURRENT" on each minor oneAPI release. We plan to have a stable API (UMF 1.0) at 2026 oneAPI release. Only since then we had to keep the backward compatibility. @pbalcer any comments on that? |
I understand that we still have no 1.0 version and can ignore backward compatibility, but it is inconvenient for development purposes. Why not support it now? It would simplify our development and we will need to implement this logic anyway, why not do it now if it is possible? |
Another thought: Since oneAPI 2025.0 compiler now uses UMF we can extend our CI to test the compiler with the mainline version of UMF. Without backward compatibility it is not possible. |
First of all we need backward compatibility tests. Without such tests, we must increase API version on each release, as we cannot guarantee anything. With those tests we can bump versions in more conscious manner.(as test will fail) Anyway - currently we have 0.X version. And based on last few weeks, we are not ready, to commit to stable API. I do not say that we can indicate api changes in more correct way, but as doing a lot of API changes ATM, probably this exercise is not huge priority, as we will bump the version on each release anyway. But adding compatibility tests is something which we should have in our backlog. |
I am not saying that we should commit to backward compatibility now and release the first stable version Why I think it is important, we are collaborating with MPI and oneCCL teams and it will be hard to make experiments. |
Environment Information
Please provide a reproduction of the bug:
libumf.so
. I compiled UMF from the source on my development machine. An tried to run the same example withLD_LIBRARY_PATH
environment to use my development version oflibumf.so
.How often bug is revealed:
always
Actual behavior:
Crashing happens because the UMF code has multiple places where we compare the current version with the version the client was built from.
Expected behavior:
The newer version of UMF should be backward compatible with the old one. E.g. oneAPI base kit 2025.0 should work with newer version of UMF.
Details
Today all our checks require an exact match, but we need to require that the current version of UMF is equal or greater that the version used by the client.
Additional information about Priority and Help Requested:
Requested priority: Showstopper
The text was updated successfully, but these errors were encountered: