-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: workflows: Reduce MacOS CI configs #2222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. The thing is it's not only GCC 14.1 which spits false positive warnings.
I have an internal PR opened to suppress those warnings, should land tomorrow. Would you mind to wait for a day? Thanks.
@theComputeKid, If this works please drop the build system changes and limit this PR to CI update. |
@vpirogov @dzarukin I've scoped the PR as suggested. But we still need:
My original change was:
|
8fcabc5
to
5ee6679
Compare
make test |
I opened an additional PR to work around this issue as well. I preferred to put a patch local to a function instead of to the whole build system. |
MacOS github runners are taking too much time. Reduced the configs as well as added more robust stale job kill policies.