Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include: Add missing DNNL_EXPERIMENTAL_UKERNEL ifdef #2211

Merged
merged 1 commit into from
Nov 13, 2024

Commits on Nov 8, 2024

  1. include: Add missing DNNL_EXPERIMENTAL_UKERNEL ifdef

    Add a missing `#ifdef DNNL_EXPERIMENTAL_UKERNEL` around `dnnl_api_utils`
    group.  The templates inside that group reference `dnnl_brgemm_t`
    and `dnnl_brgemm_pack_B_t` types that are guarded using the same
    condition, and therefore attempting to include the file without the
    define results in errors:
    
    ```
    /home/mgorny/miniforge3/envs/pytorch/include/oneapi/dnnl/dnnl_ukernel.hpp:38:22: error: ‘dnnl_brgemm_t’ was not declared in this scope; did you mean ‘dnnl_stream_t’?
       38 | struct handle_traits<dnnl_brgemm_t> {
          |                      ^~~~~~~~~~~~~
          |                      dnnl_stream_t
    /home/mgorny/miniforge3/envs/pytorch/include/oneapi/dnnl/dnnl_ukernel.hpp:38:35: error: template argument 1 is invalid
       38 | struct handle_traits<dnnl_brgemm_t> {
          |                                   ^
    /home/mgorny/miniforge3/envs/pytorch/include/oneapi/dnnl/dnnl_ukernel.hpp:45:22: error: ‘dnnl_brgemm_pack_B_t’ was not declared in this scope
       45 | struct handle_traits<dnnl_brgemm_pack_B_t> {
          |                      ^~~~~~~~~~~~~~~~~~~~
    /home/mgorny/miniforge3/envs/pytorch/include/oneapi/dnnl/dnnl_ukernel.hpp:45:42: error: template argument 1 is invalid
       45 | struct handle_traits<dnnl_brgemm_pack_B_t> {
          |                                          ^
    ```
    mgorny committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    bf90781 View commit details
    Browse the repository at this point in the history