-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental extension for metric tracer #291
Conversation
@joshuaranjan please review |
1442a13
to
7135a59
Compare
Signed-off-by: Matias Cabral <[email protected]>
Signed-off-by: Matias Cabral <[email protected]>
* Fix scripts to support two digits minor version * Extend `all_versions` array to include 1.8-1.10. * Add `ignore_git_revision` flag to run script. Signed-off-by: Matias Cabral <[email protected]> Co-authored-by: Will Damon <[email protected]>
Signed-off-by: Matias Cabral <[email protected]>
2bc659d
to
1be524b
Compare
Force push after rebasing for scripts updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Matias Cabral <[email protected]>
Signed-off-by: Matias Cabral <[email protected]>
@aravindksg, @joshuaranjan , @joshuaranjan Added a new patch to extend the metric event entry to support subdeviceId. This follows the same approach sysman already has in place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subdevice changes lgtm
9db5188
to
aad7ced
Compare
abandoning, this was already merged and available in the spec |
No description provided.