Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename zet_metric_timestamp structs to describe metric group scope #194

Open
matcabral opened this issue Aug 14, 2023 · 0 comments
Open

Comments

@matcabral
Copy link
Contributor

the structure used to get the timestamp resolution and valid bits (zet_metric_global_timestamps_resolution_exp_t ) dos NOT have global scope. As the description says, the intention is to be used with zetMetricGroupGetProperties on a per metric group granularity. So, the fact that the structure is has global as part of the name and is listed under global timestamps section is confusing and out of scope. This struct is not meant to be used with the global APIs. So, I should be renamed

From:

• zet_metric_global_timestamps_resolution_exp_t
• ze_metric_global_timestamps_exp_version_t

To:

• zet_metric_group_timestamps_resolution_exp_t
• ze_metric_group_timestamps_exp_version_t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants