Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oneall/library.js loaded on all pages when not used #79

Open
diegaless opened this issue Dec 4, 2020 · 0 comments
Open

oneall/library.js loaded on all pages when not used #79

diegaless opened this issue Dec 4, 2020 · 0 comments

Comments

@diegaless
Copy link

phpbb 3.3 - Social Login 4.7.2

I use phpbb 3.3 and from the ACP configure that oneall social login is only shown in the index. This is correct, visually it only appears in this one, however, the script is loaded in each and every one of the pages (topics, subforums, etc.), even if it is not shown. I don't know if this is a general behavior of the api (I would be surprised) or if it is a bug. This in itself is critical, since although oneall is distributed from a CDN, the latency is great especially in some locations + - 1s.

I hope someone can shed light on the matter.

Specifically this is the part of the script that is loaded and to which I refer:

`<!-- OneAll Social Login : http://www.oneall.com //-->
		<script type="text/javascript">//<![CDATA[(function(){var oa=document.createElement('script');oa.type='text/javascript';oa.async=true;oa.src='//editedforprivacy.api.oneall.com/socialize/library.js';var s=document.getElementsByTagName('script')[0];s.parentNode.insertBefore(oa,s);})();//]]></script>`
@diegaless diegaless changed the title oneall/library.js loaded on all pages when not used? oneall/library.js loaded on all pages when not used Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant