-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming BundleID also Renames BundleID of iOS Extensions. #46
Comments
Hey @10ndavis , currently package doesn't support the flavor or any extensions but we will consider to add it in the future but for now it is not available. |
@onatcipli that's fine, but that's not what i'm reporting. This is a bug, in that is is renaming extensions-- and should not. |
@10ndavis same problem, did you find any solution? |
hey @OlehMysak @10ndavis , Can you have try with the latest version and let me know please? Usage changed a little bit I recommend to have look to readme before using it. |
@onatcipli The bundleId changes not only in the runner, but also in OneSignalNotificationServiceExtension, and it should be like in the 3 photos, is it possible to somehow change it only in the runner, and for OneSignalNotificationServiceExtension (in my case) or register separately, or so that it changes only the main bundle, but that left .OneSignalNotificationServiceExtension |
I found alternative package working perfect and more correct. |
Hi @onatcipli have you check package_rename_plus? |
@chandrabezzo What's the difference between package_rename and (your) package_rename_plus? |
@chandrabezzo instead of creating a new library you should create a PR for the existing one. |
I created an Extension for Awesome Notifications FCM and when using the rename package to set the BundleID of my Flutter app, it also modifies the BundleID of the extension.
Steps to repeat:
flutter pub global run rename --bundleId com.example.app -t ios
Results:
All instances of PRODUCT_BUNDLE_IDENTIFIER in project.pbxproj are renamed, thus renaming all extensions in the process.
The text was updated successfully, but these errors were encountered: