Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming BundleID also Renames BundleID of iOS Extensions. #46

Open
10ndavis opened this issue Jun 14, 2023 · 11 comments
Open

Renaming BundleID also Renames BundleID of iOS Extensions. #46

10ndavis opened this issue Jun 14, 2023 · 11 comments
Labels
enhancement New feature or request

Comments

@10ndavis
Copy link

I created an Extension for Awesome Notifications FCM and when using the rename package to set the BundleID of my Flutter app, it also modifies the BundleID of the extension.

Steps to repeat:

  • Create Flutter App
  • Add a new Extension via xcode
  • Run flutter pub global run rename --bundleId com.example.app -t ios

Results:
All instances of PRODUCT_BUNDLE_IDENTIFIER in project.pbxproj are renamed, thus renaming all extensions in the process.

@onatcipli onatcipli added the enhancement New feature or request label Sep 23, 2023
@onatcipli
Copy link
Owner

Hey @10ndavis , currently package doesn't support the flavor or any extensions but we will consider to add it in the future but for now it is not available.

@10ndavis
Copy link
Author

@onatcipli that's fine, but that's not what i'm reporting. This is a bug, in that is is renaming extensions-- and should not.

@OlehMysak
Copy link

@10ndavis same problem, did you find any solution?

@onatcipli
Copy link
Owner

hey @OlehMysak @10ndavis , Can you have try with the latest version and let me know please?

Usage changed a little bit I recommend to have look to readme before using it.

pub.dev/packages/rename

@OlehMysak
Copy link

OlehMysak commented Oct 2, 2023

@onatcipli
Screenshot 2023-10-02 at 13 35 09
Screenshot 2023-10-02 at 13 35 39
Screenshot 2023-10-02 at 13 36 10
I updated to latest version, but have same issue

The bundleId changes not only in the runner, but also in OneSignalNotificationServiceExtension, and it should be like in the 3 photos, is it possible to somehow change it only in the runner, and for OneSignalNotificationServiceExtension (in my case) or register separately, or so that it changes only the main bundle, but that left .OneSignalNotificationServiceExtension

@quyenvsp
Copy link

I found alternative package working perfect and more correct.

https://github.com/OutdatedGuy/package_rename

@chandrabezzo
Copy link

Hi @onatcipli have you check package_rename_plus?

@songpola
Copy link

songpola commented May 1, 2024

@chandrabezzo What's the difference between package_rename and (your) package_rename_plus?

@chandrabezzo
Copy link

@songpola the different is about the key override_old_package on iOS. So, we can safely renamed the bundle identifier from your another target like NotificationService, PushTemplateExtension, and etc. Related to the issue that raised.

@songpola
Copy link

songpola commented May 7, 2024

@songpola the different is about the key override_old_package on iOS. So, we can safely renamed the bundle identifier from your another target like NotificationService, PushTemplateExtension, and etc. Related to the issue that raised.

Nice! This should be noted in your README too :)

@MDSADABWASIM
Copy link

@chandrabezzo instead of creating a new library you should create a PR for the existing one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants