Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running command in foreground blocks other processes #34

Open
mg-code opened this issue Aug 8, 2018 · 2 comments
Open

Running command in foreground blocks other processes #34

mg-code opened this issue Aug 8, 2018 · 2 comments

Comments

@mg-code
Copy link

mg-code commented Aug 8, 2018

Currently if you are using callbacks, commands are blocking other commands from execution.

It would be nice to have solution that does not have this problem.

I have done some research on this.
We could restructurize code a little bit. After starting an event we could send it to some watcher that checks status of events.
Inside runCommandInForeground function we could use start instead of run function from symfony process class and our watcher can check state using isRunning function from symfony process. After command stops we could run our callbacks and pass output as parameter using getOutput and getErrorOutput from symfony process class.

What is your opinion on this?

@pistolla
Copy link

This would be pretty useful for multi-processing

@augusl
Copy link

augusl commented Apr 21, 2020

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants