Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring of the bridge logic to work with authorities #1

Closed
akolotov opened this issue Feb 13, 2018 · 2 comments
Closed

refactoring of the bridge logic to work with authorities #1

akolotov opened this issue Feb 13, 2018 · 2 comments
Assignees
Labels

Comments

@akolotov
Copy link
Collaborator

I looked at the project swarmcity prepared: https://github.com/swarmcity/SCLabs-erc20-bridge/tree/master/contracts.

Seems that we can use great ideas for the bridge logic decomposition:

  1. Since logic of working with authorities is the same for both bridge contracts introduce it in separate contract.
  2. Do authorities as a map instead of an array. It will reduce gas consumption.
@akolotov
Copy link
Collaborator Author

And I will create an issue in the main project to address functionality of extendable list of authorities similar to paritytech/parity-bridge#33.

@akolotov akolotov changed the title refactoring of the bridge logic refactoring of the bridge logic to work with authorities Feb 13, 2018
@rstormsf
Copy link
Contributor

@akolotov so I started learning this story and I couldn't understand what needs to be done.

akolotov pushed a commit that referenced this issue Mar 6, 2019
* unit tests - factories

* unit tests - mapper

* added bridge factories and mapper to gas consumption doc

* typo

* rename event to fix "[ethjs-abi] while decoding address data, invalid address data" in tests
dforsten pushed a commit to lab10-coop/artis-bridge-contracts that referenced this issue Mar 11, 2019
dforsten pushed a commit to lab10-coop/artis-bridge-contracts that referenced this issue Mar 11, 2019
dforsten pushed a commit to lab10-coop/artis-bridge-contracts that referenced this issue Mar 11, 2019
dforsten pushed a commit to lab10-coop/artis-bridge-contracts that referenced this issue Mar 11, 2019
…contract which can't receive or otherwise handle ETH. refs omni#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants