Improve evm event log sorting

[corverroos]

Problem to Solve

We current do the following sorting of evm event logs in octane:

		topicI := slices.Concat(events[i].Topics...)
		topicJ := slices.Concat(events[j].Topics...)
		if cmp := bytes.Compare(topicI, topicJ); cmp != 0 {
			return cmp < 0
		}

The spearbit audit raised that this could be replaced with:

if cmp := slices.CompareFunc(events[i].Topics, events[j].Topics, bytes.Compare); cmp != 0 {
	return cmp < 0
}

The suggestion is simpler and more performant, but introduces slightly different logic in some edge cases.

Proposed Solution

Replace this logic during the next network upgrade. Bumping evmengine consensus version by 1.

[chmllr]

Here's one example where the functions produce different results:

package main

import (
	"bytes"
	"fmt"
	"slices"
)

func compareConcat(a, b [][]byte) bool {
	concatA := slices.Concat(a...)
	concatB := slices.Concat(b...)
	if cmp := bytes.Compare(concatA, concatB); cmp != 0 {
		return cmp < 0
	}
	return false
}

func compareFunc(a, b [][]byte) bool {
	if cmp := slices.CompareFunc(a, b, bytes.Compare); cmp != 0 {
		return cmp < 0
	}
	return false
}

func main() {
	slicesOfBytes := []struct {
		a, b [][]byte
	}{
		// same result
		{[][]byte{[]byte("a")}, [][]byte{[]byte("b"), []byte("c")}},
		// different results
		{[][]byte{[]byte("a")}, [][]byte{[]byte(""), []byte("bc")}},
	}

	fmt.Println("Comparing slices with Concat method:")
	for _, pair := range slicesOfBytes {
		fmt.Printf("compareConcat(%v, %v) = %v\n", pair.a, pair.b, compareConcat(pair.a, pair.b))
	}

	for _, pair := range slicesOfBytes {
		fmt.Printf("compareFunc(%v, %v) = %v\n", pair.a, pair.b, compareFunc(pair.a, pair.b))
	}
}

[corverroos]

Actually, sorting events in a different order than original isn't valid, see piplabs/story#301. Closing in favour of #2106