Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make voter-state.json optional #1843

Open
corverroos opened this issue Sep 9, 2024 · 1 comment
Open

Make voter-state.json optional #1843

corverroos opened this issue Sep 9, 2024 · 1 comment
Labels
good first issue Good for newcomers sprint: ad hoc PRs or issues included mid-sprint

Comments

@corverroos
Copy link
Collaborator

Problem to Solve

Halo currently auto-generates priv_validator_state.json if it doesn't exist on startup.
Halo however crashes if voter_state.json doesn't exist on startup.

We should align the behaviour and make it easier for operators.

Proposed Solution

Auto-generate voter_state.json if it doesn't exist on startup. Log info level if it was created.

@corverroos corverroos self-assigned this Sep 9, 2024
@corverroos corverroos added the sprint: ad hoc PRs or issues included mid-sprint label Sep 9, 2024
@ttarsi ttarsi added the good first issue Good for newcomers label Sep 25, 2024
@raehat
Copy link
Contributor

raehat commented Nov 24, 2024

Hey @corverroos, I looked into this issue, seems like voter_state.json already auto-generates if it doesn't exist.

} else if err := voter.GenEmptyStateFile(voterStateFile); err != nil {

Do I understand this correctly?

Log info level if it was created.

But yes we don't log info level if it is created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers sprint: ad hoc PRs or issues included mid-sprint
Projects
None yet
Development

No branches or pull requests

4 participants