forked from aws-cloudformation/cfn-lint
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Inclusive.py
77 lines (65 loc) · 3.26 KB
/
Inclusive.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
"""
Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
SPDX-License-Identifier: MIT-0
"""
from cfnlint.rules import CloudFormationLintRule
from cfnlint.rules import RuleMatch
import cfnlint.helpers
from cfnlint.data import AdditionalSpecs
class Inclusive(CloudFormationLintRule):
"""Check Properties Resource Configuration"""
id = 'E2521'
shortdesc = 'Check Properties that are required together'
description = 'Make sure CloudFormation resource properties are included together when required'
source_url = 'https://github.com/aws-cloudformation/cfn-python-lint'
tags = ['resources']
def __init__(self):
"""Init"""
super(Inclusive, self).__init__()
inclusivespec = cfnlint.helpers.load_resource(AdditionalSpecs, 'Inclusive.json')
self.resource_types_specs = inclusivespec['ResourceTypes']
self.property_types_specs = inclusivespec['PropertyTypes']
for resource_type_spec in self.resource_types_specs:
self.resource_property_types.append(resource_type_spec)
for property_type_spec in self.property_types_specs:
self.resource_sub_property_types.append(property_type_spec)
def check(self, properties, inclusions, path, cfn):
"""Check itself"""
matches = []
if not properties:
return matches
property_sets = cfn.get_object_without_conditions(properties)
for property_set in property_sets:
obj = property_set['Object'].clean()
for prop in obj:
if prop in inclusions:
for incl_property in inclusions[prop]:
if incl_property not in obj:
if property_set['Scenario'] is None:
message = 'Property {0} should exist with {1} for {2}'
matches.append(RuleMatch(
path,
message.format(incl_property, prop, '/'.join(map(str, path)))
))
else:
scenario_text = ' and '.join(['when condition "%s" is %s' % (
k, v) for (k, v) in property_set['Scenario'].items()])
message = 'Property {0} should exist with {1} {2} for {3}'
matches.append(RuleMatch(
path,
message.format(incl_property, prop, scenario_text,
'/'.join(map(str, path)))
))
return matches
def match_resource_sub_properties(self, properties, property_type, path, cfn):
"""Match for sub properties"""
matches = []
inclusions = self.property_types_specs.get(property_type, {})
matches.extend(self.check(properties, inclusions, path, cfn))
return matches
def match_resource_properties(self, properties, resource_type, path, cfn):
"""Check CloudFormation Properties"""
matches = []
inclusions = self.resource_types_specs.get(resource_type, {})
matches.extend(self.check(properties, inclusions, path, cfn))
return matches