Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use tiles for non-big movies #456

Closed
wants to merge 1 commit into from

Conversation

will-moore
Copy link
Member

Fixes #453.

If the image is not a Big (tiled) image, then don't use tile-based loading if the image is a Movie.

@will-moore
Copy link
Member Author

I tried deploying this on idr-testing with:

pip install git+https://github.com/will-moore/omero-iviewer.git@dont_tile_movies#egg=omero-iviewer&subdirectory=plugin
# or
pip install git+https://github.com/will-moore/omero-iviewer.git@refs/pull/74/head#egg=omero-iviewer&subdirectory=plugin

but these aren't working and I also see that we no-longer do it this way on merge-ci, where we now do:

git clone -b $MERGE_PUSH_BRANCH https://github.com/$SPACE_USER/omero-iviewer.git
cd omero-iviewer/plugin
python -m build
cd dist
for x in *.tar.gz; do
    pip install -U $x # Install iviewer
done

@will-moore
Copy link
Member Author

$ git clone -b dont_tile_movies https://github.com/will-moore/omero-iviewer.git
$ cd omero-iviewer/plugin

$ source /opt/omero/web/venv3/bin/activate
$ sudo pip install build
$ python -m build
...
npm run prod
unable to execute 'npm': No such file or directory
error: command 'npm' failed with exit status 1

$ curl -sL https://rpm.nodesource.com/setup_16.x | sudo bash -
$ sudo yum install -y nodejs
$ sudo yum install ant
$ python -m build
...
./prepare_build.sh: line 30: ant: command not found

running run_prod
npm run prod
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /tmp/build-via-sdist-qqy51hg5/omero-iviewer-0.14.0.dev0/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/tmp/build-via-sdist-qqy51hg5/omero-iviewer-0.14.0.dev0/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/wmoore/.npm/_logs/2023-06-29T08_22_37_464Z-debug-0.log
error: command 'npm' failed with exit status 254

ERROR Backend subprocess exited when trying to invoke build_wheel

@jburel
Copy link
Member

jburel commented Jun 29, 2023

You are attempting to build from source and dependencies like ant are not installed

@will-moore
Copy link
Member Author

I also tried adding idr.openmicroscopy.org to the server_list on merge-ci webclient so we could test IDR data in merge-ci, but login fails - which I seem to remember has been the case before.

@will-moore
Copy link
Member Author

Closing in favour of #470

@will-moore will-moore closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

async tile loading while playing movie
2 participants