Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter thumbnails same as webclient #352

Open
will-moore opened this issue Sep 9, 2020 · 5 comments
Open

Filter thumbnails same as webclient #352

will-moore opened this issue Sep 9, 2020 · 5 comments

Comments

@will-moore
Copy link
Member

See feature request at https://forum.image.sc/t/expected-behaviour-when-opening-an-image-in-iviewer/42571/2
and filtering discussion at ome/design#107

I assume that we want the current filtering state in webclient to be replicated in iviewer when you open an image from a filtered Dataset (even when/if you can save filtered state in webclient - we want the current (unsaved) filtering.
So we'd need to dynamically pass that to the iviewer when opening an image.

Currently, if you adjust the rendering settings in the preview panel of webclient, then choose to open that image in iviewer, the current rendering settings are passed in the query string.

However, we'd need to preserve the filtering params in the query string, even when we browse to other thumbnails in iviewer. Also need to take into account the filtering when calculating the total number of thumbnails to load and in the thumbnail lazy loading (pagination).
In that case, we'd have to use a different api (not the JSON /api/) to load thumbnails since we'd need the filtering to happen server-side.

This is relevant to the current limitations in webclient filtering and pagination (see https://forum.image.sc/t/paging-behaviour-in-thumbnail-parade/42573/1). So, a server-side filtering functionality is needed for both.

@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/expected-behaviour-when-opening-an-image-in-iviewer/42571/3

@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/paging-behaviour-in-thumbnail-parade/42573/3

@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/expected-behaviour-when-opening-an-image-in-iviewer/42571/6

@will-moore
Copy link
Member Author

@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/omeroweb-visualising-images-on-filtered-sets-for-labeling/71558/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants