Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider more thorough comparison of image data in automated tests #4238

Open
melissalinkert opened this issue Sep 11, 2024 · 0 comments
Open

Comments

@melissalinkert
Copy link
Member

#4205 (review) highlights that existing automated tests do not thoroughly check for consistency of openBytes results across all planes. https://github.com/ome/bioformats/blob/develop/components/test-suite/src/loci/tests/testng/OpenBytesPerformanceTest.java was one previous attempt along similar lines, but doesn't compare all plane hashes between two commits as in the review for #4205.

One option would be to "just" expand the MD5s stored in configuration files to include all planes, and then update https://github.com/ome/bioformats/blob/develop/components/test-suite/src/loci/tests/testng/FormatReaderTest.java#L2292 and related tests to check all planes. That would require a substantial amount of configuration regeneration and will almost certainly have a significant impact on runtime of the tests, so requires some more thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant