onRippleAnimationEnd called twice

[sathvik87]

I was debugging in the fork of this library and I saw that onRippleAnimationEnd is called twice.
Though when the input is finished, onPinCodeInputed is called and then If the action was successful, activity is closed. If not, an event on ui thread blocks the second handler for the onRippleAnimationEnd. I am not sure if this was the intended design.

I am working on adding better hashing method which has to be done asynchronously. When I try to do that I cannot prevent the second onRippleAnimationEnd control.

I updated to the new RippleEffect in my forked library whose onCompleteListener is called only once.

[oliveeyay]

Hello @sathvik87
Interesting!
So from what I understand, we should update to one of the latest version of RippleEffect to not have this bug anymore.
I did not encounter it on my devices though ^^

Cheers

[sathvik87]

Yes, I updated the RippleEffect library and the view code in master branch has changed quite a bit I think. If we pull the latest version available through Gradle for RippleEffect, It has a bug for Android 6.0 devices. traex/RippleEffect#103

So I had to download the latest code and integrate it as a part of external library in my project.
But, yes, When I did that, onCompletionListener is called only once. I noticed that code of RippleEffect OG fork is quite different from the current master branch.

[oliveeyay]

@sathvik87
I did not reproduce the bug with onCompletionListener called twice.
I'm gonna close it for now, I'll merge the main RippleEffect branch if I have the time.

Thanks.

Cheers

[uzbxodgiev]

@OlivierG13 Pull #215 version where correct new version of dependency is used.