Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show cursors of collaborators #80

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Show cursors of collaborators #80

wants to merge 15 commits into from

Conversation

newsch
Copy link
Member

@newsch newsch commented May 26, 2019

Closes #42

TODO:

  • fix cursor bounds problems
  • set colors consistently across clients
  • rework position message parsing
  • stop drawing clients when they quit
  • send client locations on connect
  • rework server logging
  • rebase and squash before merging
  • closes Remove GOTOs and refactor server.c #99

@newsch newsch added enhancement New feature or request network interface labels May 26, 2019
@newsch newsch self-assigned this May 26, 2019
@newsch newsch force-pushed the newsch/collab-cursors branch from 8e3eaa6 to 6af01c8 Compare May 29, 2019 04:59
@newsch newsch added this to the collascii 2020 milestone Dec 22, 2019
newsch added 15 commits August 2, 2020 15:10
Before making more breaking changes to the networking protocol (like
sending user coordinates back and forth for cursor support), it seemed
best to add a method of negotiating a protocol version so things can
fail or downgrade more gracefully.

As implemented here, previous versions of servers and clients will not
work with these updated versions. This would be a pretty big problem,
except that as far as I know nobody uses this project regularly,
especially in a networked/remote capacity.

Because previously the client expected canvas data to be sent over
immediately, the only way that I can think of to support older clients
while not requiring that canvas send is to add a timeout on the server
that waits for a version number and then sends the canvas if nothing is
sent, which seems pretty unideal.
Cursor colors are now consistent across clients
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove GOTOs and refactor server.c Show connected client cursors ala Google Docs
1 participant