Can't get setup overrides to work

[srithon]

I'm trying to make variables show up as blue and functions red in the onedark theme, while having variables be red and functions blue in onelight. I've been trying to configure setup for a while without any progress, so I tried to recreate the issue in minimal.lua, where I had the same results. Incase it was an issue with Packer, I took the config function out of the Packer block and ran it manually, but it didn't help.

-- ignore default config and plugins
vim.opt.runtimepath:remove(vim.fn.expand("~/.config/nvim"))
vim.opt.packpath:remove(vim.fn.expand("~/.local/share/nvim/site"))

-- append test directory
local test_dir = "/tmp/onedarkpro"
vim.opt.runtimepath:append(vim.fn.expand(test_dir))
vim.opt.packpath:append(vim.fn.expand(test_dir))

-- install packer
local install_path = test_dir .. "/pack/packer/start/packer.nvim"
local install_plugins = false

if vim.fn.empty(vim.fn.glob(install_path)) > 0 then
	vim.cmd(
		"!git clone https://github.com/wbthomason/packer.nvim " .. install_path
	)
	vim.cmd("packadd packer.nvim")
	install_plugins = true
end

local packer = require("packer")

packer.init({
	package_root = test_dir .. "/pack",
	compile_path = test_dir .. "/plugin/packer_compiled.lua",
})

packer.startup(function(use)
	-- Packer can manage itself
	use("wbthomason/packer.nvim")

	use({ "nvim-treesitter/nvim-treesitter", run = ":TSUpdate" })
	use({
		"olimorris/onedarkpro.nvim",
	})

	if install_plugins then
		packer.sync()
	end
end)

local ok, treesitter = pcall(require, "nvim-treesitter.configs")
if ok then
	treesitter.setup({
		ensure_installed = "all",
		ignore_install = { "phpdoc" }, -- list of parser which cause issues or crashes
		highlight = { enable = true },
	})
end

config = function()
	local color = require("onedarkpro.helpers")
	local colors = color.get_preloaded_colors()

	vim.cmd([[ echom "Ran block" ]])

	require("onedarkpro").setup({
		colors = {
			onelight = {
				variable = colors.red,
				func = colors.blue,
			},
			onedark = {
				variable = colors.blue,
				func = colors.red,
			},
		},
		highlights = {
			Identifier = {
				fg = "${variable}",
			},
			Function = {
				fg = "${func}",
			},
		},
	})

	vim.cmd("colorscheme onedark")
end

config()

I set some random parameters to see if I could get any visual effect at all, but nothing I did seemed to work.

As you can see, the variables are still red and the functions are still blue.
Sorry if this is already covered in an existing issue, but what am I doing wrong here?

On another note, the code did not run at all when I put it in the config block under Packer.

-- ignore default config and plugins
vim.opt.runtimepath:remove(vim.fn.expand("~/.config/nvim"))
vim.opt.packpath:remove(vim.fn.expand("~/.local/share/nvim/site"))

-- append test directory
local test_dir = "/tmp/onedarkpro"
vim.opt.runtimepath:append(vim.fn.expand(test_dir))
vim.opt.packpath:append(vim.fn.expand(test_dir))

-- install packer
local install_path = test_dir .. "/pack/packer/start/packer.nvim"
local install_plugins = false

if vim.fn.empty(vim.fn.glob(install_path)) > 0 then
	vim.cmd(
		"!git clone https://github.com/wbthomason/packer.nvim " .. install_path
	)
	vim.cmd("packadd packer.nvim")
	install_plugins = true
end

local packer = require("packer")

packer.init({
	package_root = test_dir .. "/pack",
	compile_path = test_dir .. "/plugin/packer_compiled.lua",
})

packer.startup(function(use)
	-- Packer can manage itself
	use("wbthomason/packer.nvim")

	use({ "nvim-treesitter/nvim-treesitter", run = ":TSUpdate" })
	use({
		"olimorris/onedarkpro.nvim",
		config = function()
			local color = require("onedarkpro.helpers")
			local colors = color.get_preloaded_colors()

			vim.cmd([[ echom "Ran block" ]])

			require("onedarkpro").setup({
				colors = {
					onelight = {
						variable = colors.red,
						func = colors.blue,
					},
					onedark = {
						variable = colors.blue,
						func = colors.red,
					},
				},
				highlights = {
					Identifier = {
						fg = "${variable}",
					},
					Function = {
						fg = "${func}",
					},
				},
			})

			vim.cmd("colorscheme onedark")
		end,
	})

	if install_plugins then
		packer.sync()
	end
end)

local ok, treesitter = pcall(require, "nvim-treesitter.configs")
if ok then
	treesitter.setup({
		ensure_installed = "all",
		ignore_install = { "phpdoc" }, -- list of parser which cause issues or crashes
		highlight = { enable = true },
	})
end

[olimorris]

If you're using nightly, I suggest using the :Inspect command to see what highlight group is being applied or use the Treesitter Playground's command for lower Neovim versions. Treesitter will be overriding Function and Identifier

[chikko80]

@chikko80 can you raise a bug report and recreate with the minimal.lua file.

Yeah i'll try, i am completely new to Neovim, just trying to migrate from vscode but i'll do my best

[srithon]

After looking at the highlight groups, I replaced Identifier and Function with @variable and @method.call. This had an effect, but the @variable highlighting was overriding @method.call.

This was the configuration. Also, to get the colors to update I had to use :OnedarkproClean:

-- ignore default config and plugins
vim.opt.runtimepath:remove(vim.fn.expand("~/.config/nvim"))
vim.opt.packpath:remove(vim.fn.expand("~/.local/share/nvim/site"))

-- append test directory
local test_dir = "/tmp/onedarkpro"
vim.opt.runtimepath:append(vim.fn.expand(test_dir))
vim.opt.packpath:append(vim.fn.expand(test_dir))

-- install packer
local install_path = test_dir .. "/pack/packer/start/packer.nvim"
local install_plugins = false

if vim.fn.empty(vim.fn.glob(install_path)) > 0 then
	vim.cmd(
		"!git clone https://github.com/wbthomason/packer.nvim " .. install_path
	)
	vim.cmd("packadd packer.nvim")
	install_plugins = true
end

local packer = require("packer")

packer.init({
	package_root = test_dir .. "/pack",
	compile_path = test_dir .. "/plugin/packer_compiled.lua",
})

packer.startup(function(use)
	-- Packer can manage itself
	use("wbthomason/packer.nvim")

	use({ "nvim-treesitter/nvim-treesitter", run = ":TSUpdate" })

	-- Treesitter playground integrated into Neovim
	use({
		"nvim-treesitter/playground",
		requires = {
			"nvim-treesitter/nvim-treesitter",
		},
	})

	use({
		"olimorris/onedarkpro.nvim",
		config = function()
			local color = require("onedarkpro.helpers")
			local colors = color.get_preloaded_colors()

			vim.cmd [[ echom "Ran" ]]

			require("onedarkpro").setup({
				colors = {
					onelight = {
						variable = colors.red,
						func = colors.blue,
					},
					onedark = {
						variable = colors.blue,
						func = colors.red,
					},
				},
				highlights = {
					["@method.call"] = {
						fg = "${func}"
					},
					["@function"] = {
						fg = "${func}"
					},
					["@variable"] = {
						fg = "${variable}"
					},
				},
			})

			vim.cmd [[ colorscheme onedark ]]
		end,
	})

	if install_plugins then
		packer.sync()
	end
end)

local ok, treesitter = pcall(require, "nvim-treesitter.configs")
if ok then
	treesitter.setup({
		ensure_installed = "python",
		ignore_install = { "phpdoc" }, -- list of parser which cause issues or crashes
		highlight = { enable = true },
	})
end

[olimorris]

I've just pushed some commits. Let me know if it's worked for you

[srithon]

Thanks! I saw the #175 issue and realized that I was having the same issue: the filetype-specific Treesitter highlights were overriding mine. I fixed it by disabling the filetype highlights for all the provided languages. With that said, would there be a way to solve the issue without disabling the filetype highlighting entirely? If we had the highlights in setup() override the defaults for each filetype, for instance, we could customize other highlight groups per-filetype rather than losing the ability to do so altogether.

[olimorris]

@srithon this should be fixed now. Not sure what was happening before but highlight overrides are applied last on top of all the theme's defaults.

If this still isn't the case (and unfortunately it's working fine in my config), please raise a bug report and I can look into it.