Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Cleanup Navigation #1366

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Cleanup Navigation #1366

merged 2 commits into from
Apr 11, 2019

Conversation

derweili
Copy link
Collaborator

@derweili derweili commented Mar 1, 2019

This PR Resolves #1364 and #1365

This PR has following changes:

  • Unnecessary stylings in the navigation.scss removed
  • Tob Bar and Menus Variables in the settings.scss changed to defaults
  • Changing Mobile menu Toggle to toggle the Top-Bar instead of the mobile nav inside the top-bar-right

Styling removed to stay closer to the default foundation-sites styling
now toggling the whole top bar instead of a the mobile nav inside the 
top-bar-right according to the foundation-sites docs
https://foundation.zurb.com/sites/docs/top-bar.html
@olefredrik olefredrik merged commit 641315f into master Apr 11, 2019
@olefredrik olefredrik deleted the navigation-cleanup branch April 11, 2019 18:16
@nitrokevin
Copy link

If we are getting rid of the dark-nav-color from the navigation, should it be removed from the off-canvas too?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pseudo elements cannot be applied to links with dropdown menus
3 participants