Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not getting ActionCable connected() when using litecable adapter #59

Closed
westonganger opened this issue Nov 2, 2023 · 8 comments
Closed

Comments

@westonganger
Copy link
Contributor

westonganger commented Nov 2, 2023

In development when I switch to adapter: litecable in config/cable.yml then it is not calling the connected() function. It does successfully call the initialized() function.

Everything works correctly when I switch back to adapter: async where I get connected() and received()

I am using puma gem for development server on Rails 7.1. Let me know if there is any other information that would be helpful.

@adrienpoly
Copy link
Contributor

I think I had a similar issue but this should be fixed on master by #41

@westonganger
Copy link
Contributor Author

Yup switch to the master branch fixes this. Maybe we could have a new version released that has a functioning LiteCable implementation.

@westonganger
Copy link
Contributor Author

Also would be really helpful to add a changelog entry stating this fix.

@westonganger
Copy link
Contributor Author

westonganger commented Nov 2, 2023

@adrienpoly I see that you were trying to add a spec for this regression in another project adrienpoly/rubyvideo#50

Would be awesome if maybe we could get a spec for this inside the litestack repo itself.

@adrienpoly
Copy link
Contributor

For sure yes I wanted to build a dummy app to add to the project but clearly running out of time right now. I f you can propose something that would be great for sure

@westonganger
Copy link
Contributor Author

Yeah sure, I have the dummy app setup in all my other gems, so I can whip up a PR to get something going.

@westonganger
Copy link
Contributor Author

Added some PRs to resolve a few of these items

@oldmoe
Copy link
Owner

oldmoe commented Nov 3, 2023

I am planning a new release soon that will include all the pending fixes/improvements, just checking what else I can sneak in

@oldmoe oldmoe closed this as completed Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants