Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe does break the google font request #29

Open
iuliaL opened this issue May 4, 2018 · 0 comments
Open

Pipe does break the google font request #29

iuliaL opened this issue May 4, 2018 · 0 comments

Comments

@iuliaL
Copy link

iuliaL commented May 4, 2018

This is not true any more
https://github.com/ojdx/react-font-face/blob/develop/src/react-font-face.js#L48
This pipe at the end should be removed cause it does break the request now
see for yourself
https://fonts.googleapis.com/css?family=Exo|

consider adding googleFontImportString.slice(0, -1) here https://github.com/ojdx/react-font-face/blob/develop/src/react-font-face.js#L51

Thank you for the lib.
I've used it before until this issue arised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant