Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require an update to DaisyPatchSM audio init to track latest libdaisy changes #462

Open
jazamatronic opened this issue Oct 25, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@jazamatronic
Copy link

G'day,

I had to update the _audio.Init() here to compile when using a recent libdaisy.

I can create a pull request if you'd like.

Cheers

@ohmtech-rdi
Copy link
Owner

Hi, and thanks again for your report.

Indeed our version of libDaisy is a bit old, didn't see that v5.x came out.

For this, we need to update the commit on which the libDaisy submodule sits on. For now we are on the v4.0.0 tag.

@jazamatronic what minimum version of libDaisy would you need for your project? You can find a list of their version tags here.

I think I'll take the issue from there.

Thanks!

@ohmtech-rdi ohmtech-rdi self-assigned this Oct 26, 2022
@ohmtech-rdi ohmtech-rdi added the enhancement New feature or request label Oct 26, 2022
@jazamatronic
Copy link
Author

Ok, that one's my fault, I didn't init the libDaisy submodule and instead just linked to my local clone which is fairly recent. No particular requirement for me as of yet, I'd been using a very old libDaisy and cloned a new to get patch_sm support.

Cheers

@ohmtech-rdi
Copy link
Owner

ohmtech-rdi commented Oct 26, 2022

Ah ok. Then could you please:

git submodule update --init --recursive

And tell me if v4 works for you?

If that's the case, I would close this issue, but create another one to generally update to one of v5.x and I'll check with Electrosmith what's in there that could benefit the project. What do you think? @jazamatronic

@jazamatronic
Copy link
Author

G'day @ohmtech-rdi,

Yeah - it build's just fine if I init the submodules as documented. It can stay the way it is, I have my local fixes for the version I'm using and we'll know what to change the day you decide to update.

Cheers

@ohmtech-rdi
Copy link
Owner

FYI, the libDaisy bootloader had a bug which would prevent to use kivu12 together with QSPI mode (ie section qspi). This has been already fixed and waiting to be merged.

I have a WIP branch to update libDaisy as soon as they merge their fix in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants