Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally run docs-pages-build #362

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conditionally run docs-pages-build #362

merged 1 commit into from
Feb 13, 2024

Conversation

pxlfrk
Copy link
Contributor

@pxlfrk pxlfrk commented Feb 13, 2024

This PR changes the workflow to rebuild the docs on github-pages to only run, when content inside the docs/ folder is changed. Currently with every push on main the docs are rebuilt, even when no changes have been made.

Signed-off-by: Achim Krämer <[email protected]>
Copy link
Member

@m90 m90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you.

@m90 m90 merged commit 0fe983d into offen:main Feb 13, 2024
2 checks passed
@m90
Copy link
Member

m90 commented Feb 13, 2024

I just noticed (obviously after merging) we forgot one thing here: the docs should obviously also be deployed anew when the workflow file itself changes, i.e. something in the build process changes. No need to fix it right now though, I'll put it on my list.

@m90
Copy link
Member

m90 commented Feb 13, 2024

Fixed in fb4663b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants