Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document socket-proxy permissions, return early when update failed on scaling down #343

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Document socket-proxy permissions, return early when update failed on scaling down #343

merged 5 commits into from
Feb 5, 2024

Conversation

m90
Copy link
Member

@m90 m90 commented Feb 4, 2024

Closes #342

@m90 m90 changed the title Document socket proxypermissions, return early when update failed on scaling down Document socket-proxy permissions, return early when update failed on scaling down Feb 4, 2024
@m90
Copy link
Member Author

m90 commented Feb 4, 2024 •
edited
Loading

@pixxon Maybe you can have a quick look at the table of permissions, as I'm not a docker-socket-proxy user myself, I might have missed something here and there, and a quick sanity check would be much appreciated.

image

@pixxon
Copy link
Contributor

pixxon commented Feb 5, 2024

I am not entirely sure what is going on, but seemingly ALLOW_STOP and ALLOW_START are useless. Without the POST permission, they just fail. ( Makes sense since it is a POST request. ) However the CONTAINERS allows stop and start anyway.

Related stop and start requests:

dockerfrontend dockerbackend/dockersocket 0/0/0/10305/10305 204 176 - - ---- 1/1/0/0/0 0/0 "POST /v1.43/containers/b8f0c74331b45c4242d0c72375ffa605278700a8d38cf4622d31cb1c06ccf6ae/stop HTTP/1.1"
dockerfrontend dockerbackend/dockersocket 0/0/0/240/240 204 176 - - ---- 1/1/0/0/0 0/0 "POST /v1.43/containers/b8f0c74331b45c4242d0c72375ffa605278700a8d38cf4622d31cb1c06ccf6ae/start HTTP/1.1"

@m90
Copy link
Member Author

m90 commented Feb 5, 2024

Thanks 🎩

@m90 m90 merged commit 0f224e4 into main Feb 5, 2024
2 checks passed
@m90 m90 deleted the socket-proxy branch February 5, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixxon pixxon pixxon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unexpected behaviour with docker socket proxy
2 participants
@m90 @pixxon