-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Azure Blob Storage #171
Conversation
README.md
Outdated
environment: | ||
AZURE_STORAGE_CONTAINER_NAME: backup-container | ||
AZURE_STORAGE_ACCOUNT_NAME: account-name | ||
AZURE_STORAGE_PRIMARY_ACCOUNT_NAME: Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo - should be KEY. It would be great if we could optionally specify the AZURE_STORAGE_ENDPOINT
ourselves as many of us might use an Azure Private Endpoint or (a bit more unlikely) use something like government cloud.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch.
It would be great if we could optionally specify the AZURE_STORAGE_ENDPOINT ourselves
This is already supported, but it's great you mention it because I'm not sure if it covers all the cases. Right now, the default value for AZURE_STORAGE_ENDPOINT
is https://{{ .AccountName }}.blob.core.windows.net/
where .AccountName
will be replaced with the account name. When passing a custom value you could either also use the templating or just hardcode whatever you need to / want to. Would this be flexible enough to cover private endpoints and/or gov cloud scenarios?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, yes you’re spot on!
Closes #101