Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] upgrade shoutrrr to v0.8.0 to support custom fields in calls to Generic Webhooks #447

Closed
huyz opened this issue Jul 28, 2024 · 3 comments · Fixed by #450
Closed

[FR] upgrade shoutrrr to v0.8.0 to support custom fields in calls to Generic Webhooks #447

huyz opened this issue Jul 28, 2024 · 3 comments · Fixed by #450
Labels
dependencies Pull requests that update a dependency file pr welcome

Comments

@huyz
Copy link

huyz commented Jul 28, 2024

Is your feature request related to a problem? Please describe.

I have notifications sent to a Generic Webhook endpoint. But I'm in need of fields other than title and message to be sent.

Describe the solution you'd like

In order to support https://containrrr.dev/shoutrrr/dev/services/generic/#custom_data_fields , please bump the shoutrrr dependency to v0.8.0 to benefit from these commits: containrrr/shoutrrr#377

Describe alternatives you've considered

I current use hacks to inject data in the title and message fields and have to do special processing to extract that data.

@m90
Copy link
Member

m90 commented Jul 28, 2024

Happy to merge and release a PR that updates this, in case anyone wants to do it.

@m90 m90 added pr welcome dependencies Pull requests that update a dependency file labels Jul 28, 2024
@m90 m90 closed this as completed in #450 Jul 31, 2024
@huyz
Copy link
Author

huyz commented Jul 31, 2024

Thanks @m90 !

@m90
Copy link
Member

m90 commented Jul 31, 2024

This is now included in v2.40.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file pr welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants