-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilize GH Workflow to publish to PyPI #654
Conversation
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
=======================================
Coverage 27.28% 27.28%
=======================================
Files 7 7
Lines 1246 1246
Branches 191 191
=======================================
Hits 340 340
Misses 881 881
Partials 25 25 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ibnesayeed Will this keep the releases on GitHub and pypi in step?
Releases on GH will be performed the same way as before (i.e., by running |
Ok, this process should probably be documented. It's starting to sound a little Rube Goldberg-esque. |
I don't think we need to document something that is of no interest of users. For maintainers of a repo the process is being widely adopted by the GH community that it will become obvious how things are done, especially, these YAML files are rather self-descriptive. I feel like documenting it is similar to if every repo using a Dockerfile were to document what Docker is, how it works, and how to install it. If one has used any CI system before, things will be easy to follow and GH has great documentation on how various pieces work. |
It is not for the users, @ibnesayeed, it is for me. Despite what is being adopted, "future us" would like to know. He has an axe. |
Fair enough! Which steps of the process do you think are not very straight-forward and you need to document them somewhere for future reference? I can try to explain. |
A wiki page would be good that we could link from the README. I think I understand the process but will likely not look back on this GH issue (or PR!), so...adapt the above, in your words of expertise, to an external place. |
I have added some inline documentation in some obvious places where I think you might look when you need some clarifications. |
This implements the last point of #630. Also, related to #649.