Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts-odd unit tests running in browsers #548

Open
bdehaynin opened this issue Aug 4, 2023 · 2 comments
Open

ts-odd unit tests running in browsers #548

bdehaynin opened this issue Aug 4, 2023 · 2 comments

Comments

@bdehaynin
Copy link

bdehaynin commented Aug 4, 2023

Summary

Problem

Unit tests are currently run in node only. They may unexpectedly fail in the browser.

Impact

We may miss some error cases.

Solution

Run unit tests in headless browsers using playwright-test.

@bgins bgins removed their assignment Aug 21, 2023
@bgins
Copy link
Member

bgins commented Aug 21, 2023

A first step in the task was completed by updating the unit tests to use assert instead of expect: #541

In addition, packaging changes were needed in rs-wnfs to support both node and headless browsers at the simultaneously: wnfs-wg/rs-wnfs#318

The ODD SDK needs a few other changes to align with this newer version of rs-wnfs. When that is complete, it should be possible to get the browser tests running.

@icidasset
Copy link
Contributor

@bgins I just upgraded to the latest rs-wnfs with your wasm packaging changes on the next branch. PR that was merged recently: #536

@hugomrdias hugomrdias removed their assignment Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants