Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AuthenticationCommandPort #78

Closed
Feyzanrs opened this issue May 19, 2024 · 0 comments · Fixed by #96
Closed

Remove AuthenticationCommandPort #78

Feyzanrs opened this issue May 19, 2024 · 0 comments · Fixed by #96
Assignees
Labels
Be enhancement New feature or request refactor Improvements or restructuring of existing functionality

Comments

@Feyzanrs
Copy link
Member

Feyzanrs commented May 19, 2024

The AuthenticationCommandPort is being removed from CommandPort interface in the application layer. Authentication processes will now be handled by the Auth service, which communicates with the presentation layer.

Path of the file to be changed

internal/application/presentation/port/command/command.go

Code to be Removed

    AuthenticationCommandPort

Updated Code

package application

// CommandPort is a port for Hexagonal Architecture Pattern.
// It is used to communicate with the application layer.
type CommandPort interface {
	LoggingCommandPort
	UserCommandPort
}

The changes will be merged into the enhance/team/66/implement-password-validation branch first. Therefore, set the base branch of the pull request as enhance/team/66/implement-password-validation.

@Feyzanrs Feyzanrs added enhancement New feature or request refactor Improvements or restructuring of existing functionality labels May 19, 2024
@Maraza25 Maraza25 linked a pull request Jun 10, 2024 that will close this issue
@Maraza25 Maraza25 linked a pull request Jun 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Be enhancement New feature or request refactor Improvements or restructuring of existing functionality
Projects
None yet
3 participants