Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove User gRPC Functions from Presentation #29

Closed
Feyzanrs opened this issue May 19, 2024 · 0 comments
Closed

Remove User gRPC Functions from Presentation #29

Feyzanrs opened this issue May 19, 2024 · 0 comments
Assignees
@Smnrgcl
Labels
Be Be Team medium-priority Important issues to be addressed soon refactor Improvements or restructuring of existing functionality

Comments

@Feyzanrs
Copy link
Member

We need to eliminate the gRPC communication functions related to user operations from the pkg/presentation/controller/grpc directory.

Files to Remove:

  • pkg/presentation/controller/grpc/user.go
  • pkg/presentation/controller/grpc/user_test.go

The changes will be merged into the first/hsm/1/create-first branch first. Therefore, set the base branch of the pull request as first/hsm/1/create-first.
@Feyzanrs Feyzanrs added medium-priority Important issues to be addressed soon refactor Improvements or restructuring of existing functionality labels May 19, 2024
@octopos-prime octopos-prime added the Be Be Team label May 19, 2024
@Smnrgcl Smnrgcl mentioned this issue May 20, 2024
Merged
@Smnrgcl Smnrgcl closed this as completed May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Smnrgcl Smnrgcl

Labels
Be Be Team medium-priority Important issues to be addressed soon refactor Improvements or restructuring of existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Feyzanrs @Smnrgcl @octopos-prime